| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, magnus(at)hagander(dot)net |
| Subject: | Re: New windows compiler warning from 585bca39 |
| Date: | 2014-04-18 08:10:29 |
| Message-ID: | 20140418081029.GA28349@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 17, 2014 at 04:14:55PM -0400, Tom Lane wrote:
> > Perhaps the #ifndef could be placed in a nicer spot in the patch, but the
> > attached should at least describe where the problem lies...
>
> Yeah, I thought it better to make a separate declaration to wrap in
> #ifndef. pgindent is probably going to insist on adding some vertical
> whitespace around the #if, and that'll look horrid if it's just in the
> middle of a list of variables.
Uh, I don't think that is the case anymore.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2014-04-18 08:14:16 | Re: Archive recovery won't be completed on some situation. |
| Previous Message | Albe Laurenz | 2014-04-18 07:42:06 | Re: [GENERAL] client encoding that psql command sets |