Re: [PATCH] pg_statio_all_tables: several rows per table due to invalid TOAST index

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrei Zubkov <zubkov(at)moonset(dot)ru>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] pg_statio_all_tables: several rows per table due to invalid TOAST index
Date: 2022-03-25 13:28:58
Message-ID: 3235677.1648214938@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrei Zubkov <zubkov(at)moonset(dot)ru> writes:
> Thank you for your attention and for the problem resolution. However
> I'm worry a little about possible performance issues related to
> monitoring solutions performing regular sampling of statistic views to
> find out the most intensive objects in a database.

There's no actual evidence that the new formulation is meaningfully
worse for such cases. Sure, it's probably *somewhat* less efficient,
but that could easily be swamped by pgstat or other costs. I wouldn't
care to worry about this unless some evidence is presented that we've
created a big problem.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-03-25 13:32:44 Re: automatically generating node support functions
Previous Message Japin Li 2022-03-25 13:28:42 Re: pg_relation_size on partitioned table