Re: Emacs vs pg_indent's weird indentation for function declarations

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: Emacs vs pg_indent's weird indentation for function declarations
Date: 2019-05-19 17:27:21
Message-ID: 32165.1558286841@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> writes:
> On 17/05/2019 16.48, Tom Lane wrote:
>> It doesn't really seem practical to me to make the lookahead function
>> smart enough to tell the difference between attributes and K&R-style
>> parameter declarations. What I'm thinking of doing to have an
>> upstreamable patch is to invent a new switch, perhaps '-kr'/'-nkr',
>> to indicate whether the user is more worried about K&R function
>> declarations than she is about function attributes.

> I think it's safe to assume that upstream can drop support for K&R-style
> parameters altogether.

Cool. I already created the switch, but maybe we could have it
default to -nkr?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2019-05-19 17:38:45 Re: Multivariate MCV stats can leak data to unprivileged users
Previous Message Piotr Stefaniak 2019-05-19 17:25:05 Re: Emacs vs pg_indent's weird indentation for function declarations