Re: pgsql: Superuser can permit passwordless connections on postgres_fdw

I wrote:
> This is a bit messier. But I think that the discrepancy is not
> really the fault of this patch: rather, it's a bug in the way the
> GSS support was put into libpq. I thought we had a policy that
> all builds would recognize all possible parameters and then
> perhaps fail later. Certainly the SSL parameters are implemented
> that way. The #if's disabling GSS stuff in PQconninfoOptions[]
> are just broken, according to that policy.

Concretely, I think we ought to do (and back-patch) the attached.

I notice in testing this that the "nosuper" business added by
6136e94dc is broken in more ways than what the buildfarm is
complaining about: it leaves the role around at the end of the
test. That's a HUGE violation of project policy, for security
reasons as well as the fact that it makes it impossible to run
"make installcheck" twice without getting different results.

regards, tom lane