From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Superuser can permit passwordless connections on postgres_fdw |
Date: | 2019-12-21 02:18:06 |
Message-ID: | 20191221021806.GA15758@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Fri, Dec 20, 2019 at 02:42:22PM -0500, Tom Lane wrote:
> Concretely, I think we ought to do (and back-patch) the attached.
Thanks for the fix, I have not been able to look at that.
> I notice in testing this that the "nosuper" business added by
> 6136e94dc is broken in more ways than what the buildfarm is
> complaining about: it leaves the role around at the end of the
> test. That's a HUGE violation of project policy, for security
> reasons as well as the fact that it makes it impossible to run
> "make installcheck" twice without getting different results.
Roles left behind at the end of a test are annoying. Here is an idea:
make pg_regress check if any roles prefixed by "regress_" are left
behind at the end of a test. This will not work until test_pg_dump is
cleaned up, just a thought.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-12-21 03:17:20 | Re: pgsql: Superuser can permit passwordless connections on postgres_fdw |
Previous Message | Jeremy Schneider | 2019-12-20 23:21:30 | Re: logical decoding bug: segfault in ReorderBufferToastReplace() |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2019-12-21 02:29:33 | Re: Hooks for session start and end, take two |
Previous Message | Bossart, Nathan | 2019-12-21 01:18:24 | Re: archive status ".ready" files may be created too early |