Re: executor relation handling

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: executor relation handling
Date: 2018-10-01 02:49:18
Message-ID: 31971.1538362158@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> On 1 October 2018 at 06:18, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> + for (slockmode = lockmode + 1;
>> + slockmode <= AccessExclusiveLock;
>> + slockmode++)

> So would it not be better to add the following to lockdefs.h?
> #define MaxLockLevel 8
> then use that to terminate the loop.

Good idea, will do.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-10-01 03:34:23 Re: automatic restore point
Previous Message David Rowley 2018-10-01 02:35:30 Re: Some incorrect comments and out-dated README from run-time pruning