| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Anton A(dot) Melnikov" <aamelnikov(at)inbox(dot)ru> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Richard Guo <guofenglinux(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, "Finnerty, Jim" <jfinnert(at)amazon(dot)com> |
| Subject: | Re: Making Vars outer-join aware |
| Date: | 2023-05-04 12:22:04 |
| Message-ID: | 3197069.1683202924@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Anton A. Melnikov" <aamelnikov(at)inbox(dot)ru> writes:
> The thing is that for custom scan nodes as readme says:
> "INDEX_VAR is abused to signify references to columns of a custom scan tuple type"
> But INDEX_VAR has a negative value, so it can not be used in varnullingrels bitmapset.
> And therefore this improvement seems will not work with custom scan nodes and some
> extensions that use such nodes.
Under what circumstances would you be trying to inject INDEX_VAR
into a nullingrel set? Only outer-join relids should ever appear there.
AFAICS the change you propose would serve only to mask bugs.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-05-04 12:39:03 | Re: PL/Python: Fix return in the middle of PG_TRY() block. |
| Previous Message | Daniel Gustafsson | 2023-05-04 12:18:13 | Re: evtcache: EventTriggerCache vs Event Trigger Cache |