Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.
Date: 2019-01-03 18:40:42
Message-ID: 31665.1546540842@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

I noticed that this patch has broken restores of existing dump files:

psql:testbed.public.backup:82: ERROR: unrecognized configuration parameter "default_with_oids"

Quite aside from the fact that this won't work if the user tries to
restore in single-transaction or no-error mode, this is really really
unhelpful because it's impossible to tell whether the error is
ignorable or not, except by digging through the dump file.

What you should do is restore that GUC, but add a check-hook that throws
an error for an attempt to set it to "true".

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2019-01-03 18:47:13 Re: GiST VACUUM
Previous Message Alvaro Herrera 2019-01-03 18:38:30 Re: Logical decoding for operations on zheap tables

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2019-01-03 21:08:25 Re: pgsql: Update ssl test certificates and keys
Previous Message Peter Eisentraut 2019-01-03 14:36:36 Re: pgsql: Update ssl test certificates and keys