From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org, Bernd Helmle <mailings(at)oopsware(dot)de> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: Bug in WAL backup documentation |
Date: | 2006-11-03 16:25:09 |
Message-ID: | 3166.1162571109@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Bernd Helmle <mailings(at)oopsware(dot)de> writes:
> Our WAL backup documentation says in some parts of it:
> ..."%p is replaced by the absolute path of the file to archive..." [1]
> I think this is (at least for 8.1 and upcoming 8.2 releases) wrong, since
> the archiver replaces this with pg_xlog/<LOGFILENAME> only,
Good point. Do we want to consider that this is a code bug rather than
a doc bug? The relative path is more efficient as long as the archiver
script doesn't do a "cd", but if it does then there'd be a problem.
You could argue that the code should be tweaked to continue supplying
an absolute path.
Since 8.1 has done this all along and no one's actually complained about
it, I guess no one is using scripts that do "cd". I'm inclined to go
with Bernd's suggestion to change the docs to match the code, but does
anyone have a contrary opinion?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Joshua D. Drake | 2006-11-03 16:27:36 | Re: Design Considerations for New Authentication Methods |
Previous Message | Richard Troy | 2006-11-03 15:13:26 | Re: [HACKERS] "recovering prepared transaction" after serverrestart |
From | Date | Subject | |
---|---|---|---|
Next Message | Martijn van Oosterhout | 2006-11-03 16:34:16 | Re: [HACKERS] Bug in WAL backup documentation |
Previous Message | Alvaro Herrera | 2006-11-03 13:45:04 | Re: [PATCHES] WAL logging freezing |