From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Subject: | Re: retry shm attach for windows (WAS: Re: OK, so culicidae is *still* broken) |
Date: | 2017-07-10 14:46:09 |
Message-ID: | 31019.1499697969@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Jul 10, 2017 16:08, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Okay, so that leaves us with a decision to make: push it into beta2, or
>> wait till after wrap? I find it pretty scary to push a patch with
>> portability implications so soon before wrap, but a quick look at the
>> buildfarm suggests we'd get runs from 3 or 4 Windows members before the
>> wrap, if I do it quickly. If we wait, then it will hit the field in
>> production releases with reasonable buildfarm testing but little more.
>> That's also pretty scary.
>> On balance I'm tempted to push it now for beta2, but it's a close call.
>> Thoughts?
> Given the lack of windows testing on non packaged releases I think we
> should definitely push this for beta2. That will give it a much better real
> world testing on what is still a beta.
> If it breaks its a lot better to do it in beta2 (and possibly quickly roll
> a beta3) than in production.
Shall we go for broke and also remove the ASLR-disabling patch in beta2?
I do not feel a need to back-patch that one, at least not yet. But if
we're going to do it any time soon, a beta seems like the time.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2017-07-10 14:47:30 | Re: retry shm attach for windows (WAS: Re: OK, so culicidae is *still* broken) |
Previous Message | Magnus Hagander | 2017-07-10 14:19:49 | Re: retry shm attach for windows (WAS: Re: OK, so culicidae is *still* broken) |