| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: retry shm attach for windows (WAS: Re: OK, so culicidae is *still* broken) |
| Date: | 2017-07-10 14:47:30 |
| Message-ID: | 20170710144730.GA2189404@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 10, 2017 at 10:08:53AM -0400, Tom Lane wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
> > I recommend pushing your patch so the August back-branch releases have it.
> > One can see by inspection that your patch has negligible effect on systems
> > healthy today. I have a reasonable suspicion it will help some systems. If
> > others remain broken after this, that fact will provide a useful clue.
>
> Okay, so that leaves us with a decision to make: push it into beta2, or
> wait till after wrap? I find it pretty scary to push a patch with
> portability implications so soon before wrap, but a quick look at the
> buildfarm suggests we'd get runs from 3 or 4 Windows members before the
> wrap, if I do it quickly. If we wait, then it will hit the field in
> production releases with reasonable buildfarm testing but little more.
> That's also pretty scary.
>
> On balance I'm tempted to push it now for beta2, but it's a close call.
> Thoughts?
Pushing now for beta2 sounds good.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2017-07-10 14:48:56 | Re: retry shm attach for windows (WAS: Re: OK, so culicidae is *still* broken) |
| Previous Message | Tom Lane | 2017-07-10 14:46:09 | Re: retry shm attach for windows (WAS: Re: OK, so culicidae is *still* broken) |