Re: [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable.

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, May 24, 2017 at 3:16 AM, Tsunakawa, Takayuki
> <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> wrote:
>> For this, I added a GUC_REPORT variable session_read_only which indicates the session's default read-only status. The characteristics are:
>>
>> * It cannot be changed directly by the user (postgresql.conf, SET, etc.)
>> * Its value is the same as default_transaction_read_only when not in recovery.

I didn't look at exactly how you tried to do that, but GUCs whose values
depend on other GUCs generally don't work well at all.

>> * Its value is false during recovery.

[ scratches head... ] Surely this should read as "true" during recovery?
Also, what happens if the standby server goes live mid-session?

>> Could you include this in PG 10?

I concur with Robert that this is too late for v10, and the argument to
shove it in anyway is not compelling.

regards, tom lane