Re: Renaming MemoryContextResetAndDeleteChildren to MemoryContextReset

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Renaming MemoryContextResetAndDeleteChildren to MemoryContextReset
Date: 2015-02-26 22:57:59
Message-ID: 30854.1424991479@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> I'd really not even be surprised if a committer backpatches a
> MemoryContextReset() addition, not realizing it behaves differently in
> the back branches.

As far as that goes, the only consequence would be a possible memory leak
in the back branches; it would not be a really fatal problem. I'd rather
live with that risk than with the sort of intentional API break (and
ensuing back-patch pain) that you're proposing.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-02-26 23:01:03 Re: [REVIEW] Re: Compression of full-page-writes
Previous Message Tom Lane 2015-02-26 22:55:51 Re: Renaming MemoryContextResetAndDeleteChildren to MemoryContextReset