Re: Add header support to text format and matching feature

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Greg Stark <stark(at)mit(dot)edu>, Rémi Lapeyre <remi(dot)lapeyre(at)lenstra(dot)fr>, Zhihong Yu <zyu(at)yugabyte(dot)com>, David Steele <david(at)pgmasters(dot)net>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Daniel Verite <daniel(at)manitou-mail(dot)org>
Subject: Re: Add header support to text format and matching feature
Date: 2022-06-15 09:14:33
Message-ID: 302a562e-f766-bf0f-f76d-e6b232bf8870@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 14.06.22 11:13, Julien Rouhaud wrote:
>> There is no need for the extra
>> comment, and the error code should be ERRCODE_FEATURE_NOT_SUPPORTED.
> Is there any rule for what error code should be used?
>
> Maybe that's just me but I understand "not supported" as "this makes sense, but
> this is currently a limitation that might be lifted later".

I tend to agree with that interpretation.

Also, when you consider the way SQL rules and error codes are set up,
errors that are detected during parse analysis should be a subclass of
"syntax error or access rule violation".

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2022-06-15 09:23:06 Re: replacing role-level NOINHERIT with a grant-level option
Previous Message Peter Smith 2022-06-15 08:56:24 Re: Handle infinite recursion in logical replication setup