| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: Making background psql nicer to use in tap tests |
| Date: | 2023-04-07 15:52:37 |
| Message-ID: | 3002205.1680882757@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2023-04-07 15:32:12 +0200, Daniel Gustafsson wrote:
>> I don't think we should go ahead with a patch that refactors interactive_psql
>> only to SKIP over it in CI (which is what the tab_completion test does now), so
>> let's wait until we have that sorted before going ahead.
> Maybe I am a bit confused, but isn't that just an existing requirement? Why
> would we expect this patchset to change what dependencies use of
> interactive_psql() has?
It is an existing requirement, but only for a test that's not too
critical. If interactive_psql starts getting used for more interesting
things, we might be sad that the coverage is weak.
Having said that, weak coverage is better than no coverage. I don't
think this point should be a show-stopper for committing.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2023-04-07 15:55:08 | Re: Making background psql nicer to use in tap tests |
| Previous Message | Andres Freund | 2023-04-07 15:47:57 | Re: Minimal logical decoding on standbys |