| From: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: Skip .DS_Store files in check_mode_recursive |
| Date: | 2026-09-01 09:19:44 |
| Message-ID: | 2e3555b2-8f95-4235-b02b-55060010dc5a@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 28/07/2026 15:21, Daniel Gustafsson wrote:
>> On 28 Jul 2026, at 13:56, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> On 2026-07-28 Tu 4:53 AM, Andrei Lepikhov wrote:
>
>>> I am repeatedly encountering an annoying failing test during 'make check-world'
>>> execution on the macOS platform: pg_resetwal with the result:
>>>
>>> Failed test 'check PGDATA permissions'
>>>
>>> It happens because a filesystem object .DS_Store exists in the directory.
>>> AFAIK, MacOS manages it on its own. Given that I almost never touch this module,
>>> it seems the OS handles it automatically.
>>>
>>> A quick dive into the mailing list history shows that this problem has been
>>> discovered [1] and partly fixed [2] before.
>>>
>>> It looks like this approach might be extended to TAP tests too. In the
>>> attachment, see the sketch of the code and a minor test to prove that it works.
>
> Off the cuff, seems reasonable.
Quick reminder: it still fails the ‘make check-world’ pass. Has it been
rejected, or should I add something else to the patch?
--
regards, Andrei Lepikhov,
pgEdge
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-09-01 09:22:05 | Re: Skip .DS_Store files in check_mode_recursive |
| Previous Message | Andrei Lepikhov | 2026-09-01 09:16:54 | Re: Do not scan index in right table if condition for left join evaluates to false using columns in left table |