Re: Skip .DS_Store files in check_mode_recursive

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: Andrei Lepikhov <lepihov(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: Skip .DS_Store files in check_mode_recursive
Date: 2026-09-01 09:22:05
Message-ID: 28435010-0003-4786-9A64-F8F378D0AED6@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 1 Sep 2026, at 11:19, Andrei Lepikhov <lepihov(at)gmail(dot)com> wrote:
>
> On 28/07/2026 15:21, Daniel Gustafsson wrote:
>>> On 28 Jul 2026, at 13:56, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>> On 2026-07-28 Tu 4:53 AM, Andrei Lepikhov wrote:
>>
>>>> I am repeatedly encountering an annoying failing test during 'make check-world'
>>>> execution on the macOS platform: pg_resetwal with the result:
>>>>
>>>> Failed test 'check PGDATA permissions'
>>>>
>>>> It happens because a filesystem object .DS_Store exists in the directory.
>>>> AFAIK, MacOS manages it on its own. Given that I almost never touch this module,
>>>> it seems the OS handles it automatically.
>>>>
>>>> A quick dive into the mailing list history shows that this problem has been
>>>> discovered [1] and partly fixed [2] before.
>>>>
>>>> It looks like this approach might be extended to TAP tests too. In the
>>>> attachment, see the sketch of the code and a minor test to prove that it works.
>>
>> Off the cuff, seems reasonable.
>
> Quick reminder: it still fails the ‘make check-world’ pass. Has it been
> rejected, or should I add something else to the patch?

Sorry for the delay. Things are just a bit slow at the moment due to everyone
being very busy with preparing 19 for GA. I'll try to get to it soon.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2026-09-01 09:36:16 Re: Proposal: Conflict log history table for Logical Replication
Previous Message Andrei Lepikhov 2026-09-01 09:19:44 Re: Skip .DS_Store files in check_mode_recursive