| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests |
| Date: | 2016-09-09 00:15:46 |
| Message-ID: | 2de9d128-d4da-b553-116d-b73ad5d37e98@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/8/16 6:04 PM, Alvaro Herrera wrote:
> Andres Freund wrote:
>> On 2016-09-08 18:13:06 -0300, Alvaro Herrera wrote:
>>> I suppose -I$(srcdir) should be fine. (Why the quotes?)
>>
>> Because quoting correctly seems like a good thing to do? Most people
>> won't have whitespace in there, but it doesn't seem impossible?
>
> Well, I think they are used without quotes in so many places that doing
> it here seems rather pointless.
We don't support build directories with spaces in them, but we support
installation directories with spaces in them. So I guess that means
your point is valid.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-09-09 00:17:05 | Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests |
| Previous Message | Craig Ringer | 2016-09-09 00:13:20 | Re: ICU integration |