| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests |
| Date: | 2016-09-09 00:17:05 |
| Message-ID: | 20160909001705.rgll3bnooc457x56@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2016-09-08 20:15:46 -0400, Peter Eisentraut wrote:
> On 9/8/16 6:04 PM, Alvaro Herrera wrote:
> > Andres Freund wrote:
> >> On 2016-09-08 18:13:06 -0300, Alvaro Herrera wrote:
> >>> I suppose -I$(srcdir) should be fine. (Why the quotes?)
> >>
> >> Because quoting correctly seems like a good thing to do? Most people
> >> won't have whitespace in there, but it doesn't seem impossible?
> >
> > Well, I think they are used without quotes in so many places that doing
> > it here seems rather pointless.
>
> We don't support build directories with spaces in them, but we support
> installation directories with spaces in them. So I guess that means
> your point is valid.
Even if not necessary in this specific case, I personally think it's
just a good to quote halfway sensibly. Especially when it's trivial to
do so.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-09-09 00:42:13 | Re: mdtruncate leaking fd.c handles? |
| Previous Message | Peter Eisentraut | 2016-09-09 00:15:46 | Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests |