| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: run pgindent in CI |
| Date: | 2026-11-05 21:34:57 |
| Message-ID: | 2dbdf3a6-933f-465e-8909-d04f540420ca@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 05.11.26 21:26, Peter Geoghegan wrote:
> On Thu, Nov 5, 2026 at 3:01 PM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>> The above have been done, so here we are back on this.
>
> It takes me about 7 seconds to run pgindent locally, on my fast
> workstation. I prefer to run it exactly as koel does, for obvious
> reasons.
>
> Are you sure that this is an appropriate use of CI cycles?
Based on my testing, 7 seconds is trivial compared to everything else
that is going on in a CI run. The CompilerWarnings job is regularly
faster than all the other jobs. We have about 5 minutes we can fill
with stuff there before it would affect the overall experience, not that
I'm proposing to do that.
> Nathan had
> a patch that made pgindent run much faster. Perhaps that should be
> committed first?
I think that would be lost in the noise on CI. It would be welcome for
local use, of course.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2026-11-05 21:41:13 | Re: PG19 regression in ecd9288624a: JSON_ARRAY() indexes that go stale |
| Previous Message | Jacob Champion | 2026-11-05 21:33:06 | Re: Emptying oauth_validator_libraries doesn't stop OAuth logins |