| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Partition-wise join for join between (declaratively) partitioned tables |
| Date: | 2017-03-24 08:27:03 |
| Message-ID: | 2d4e9d54-0d08-9aa0-6359-6b776b2f5438@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Ashutosh,
On 2017/03/23 21:48, Ashutosh Bapat wrote:
>>> I have fixed all the issues reported till now.
In patch 0007, the following code in have_partkey_equi_join() looks
potentially unsafe:
/*
* If the clause refers to different partition keys from
* both relations, it can not be used for partition-wise join.
*/
if (ipk1 != ipk2)
continue;
/*
* The clause allows partition-wise join if only it uses the same
* operator family as that specified by the partition key.
*/
if (!list_member_oid(rinfo->mergeopfamilies,
part_scheme->partopfamily[ipk1]))
continue;
What if ipk1 and ipk2 both turn out to be -1? Accessing
part_schem->partopfamily[ipk1] would be incorrect, no?
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kuntal Ghosh | 2017-03-24 08:47:50 | Re: BUG: pg_dump generates corrupted gzip file in Windows |
| Previous Message | Amit Kapila | 2017-03-24 07:54:59 | Re: pageinspect and hash indexes |