| From: | JiaoShuntian <jiaoshuntian(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | "Nishant Sharma <nishant(dot)sharma(at)enterprisedb(dot)com>Jim Jones" <jim(dot)jones(at)uni-muenster(dot)de>, Steven Niu <niushiji(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: PSQL schema "describe" \dn is not escaping quotes |
| Date: | 2026-08-17 06:18:04 |
| Message-ID: | 2b5f4599-885b-4f0d-a866-1721f201c1b8@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Peter,
I applied v3 and gave it a test today. Some notes:
1) v3-0001-Fix-escapes-for-psql-describe-schema-patterns.patch applies
cleanly with `git am` on top of current master (tip 1f97b252dfe).
2) publication regression test passes cleanly, including the new
embedded-quote cases you added. No diffs.
3) I also performed a manual test on an instance:
CREATE SCHEMA "it's a bug";
\dn "it's a bug"
With v3 applied it now correctly returns:
List of schemas
Name | Owner
------------+--------------
it's a bug | jiaoshuntian
(1 row)
So the fix behaves as described and the test coverage looks adequate
to me.
Regards,
Shuntian Jiao
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Andrei Lepikhov | 2026-08-17 06:13:29 | Allow a prosupport function to be attached to an aggregate |