| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Exclude unlogged tables from base backups |
| Date: | 2018-01-29 18:17:12 |
| Message-ID: | 2b2e1879-aa33-afb5-f62d-ea912d5d9887@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/29/18 9:13 AM, David Steele wrote:
> On 1/29/18 5:28 AM, Masahiko Sawada wrote:
>> But I
>> have a question; can we exclude temp tables as well? The pg_basebackup
>> includes even temp tables. But I don't think that it's necessary for
>> backups
> Thank you for having another look at the patch.
>
> Temp tables should be excluded by this code which is already in
> basebackup.c:
>
> /* Skip temporary files */
> if (strncmp(de->d_name,
> PG_TEMP_FILE_PREFIX,
> strlen(PG_TEMP_FILE_PREFIX)) == 0)
> continue;
>
> This looks right to me.
Whoops, my bad. Temp relations are stored in the db directories with a
"t" prefix. Looks like we can take care of those easily enough but I
think it should be a separate patch.
I'll plan to submit that for CF 2018-03.
Thanks!
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2018-01-29 18:28:18 | Re: JIT compiling with LLVM v9.0 |
| Previous Message | Simon Riggs | 2018-01-29 18:14:39 | Re: [HACKERS] MERGE SQL Statement for PG11 |