Re: [UPDATED] A GUC variable to replace PGBE_ACTIVITY_SIZE

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>
Cc: "Thomas Lee" <tom(at)vector-seven(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [UPDATED] A GUC variable to replace PGBE_ACTIVITY_SIZE
Date: 2008-07-01 13:56:13
Message-ID: 2982.1214920573@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Heikki Linnakangas" <heikki(at)enterprisedb(dot)com> writes:
> Tom Lane wrote:
>> Huh? How could we be assigning to a slot that is not in use?

> Before the patch, we loop through the shared PgBackendStatus slots
> (there is MaxBackends of them), and issue a memcpy for each to copy it
> to our local slot. After that, we check if it was actually in use.
> After the patch, we still loop through the shared slots, but only issue
> the memcpy for slots that are in use.

Oh, you're talking about *fetching* the slot contents, not *assigning*
to them. Sorry, probably should have read the patch instead of just
reacting to the comment ...

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2008-07-01 15:20:43 Re: [HACKERS] odd output in restore mode
Previous Message Heikki Linnakangas 2008-07-01 12:21:23 Re: [UPDATED] A GUC variable to replace PGBE_ACTIVITY_SIZE