Re: [HACKERS] odd output in restore mode

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Dave Page <dpage(at)pgadmin(dot)org>, List pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] odd output in restore mode
Date: 2008-07-01 15:20:43
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches

Simon Riggs wrote:
> > > * recommendation to use GnuWin32 cp on Windows
> > > * provide "holdtime" delay, default 0 (on all platforms)
> > > * default stays same on Windows="copy" to ensure people upgrading don't
> > > get stung
> >
> > This seems pretty kludgey to me. I wouldn't want to install GnuWin32
> > utilities on a production system just for the "cp" command, and I don't
> > know how I would tune holdtime properly for using "copy". And it seems
> > risky to have defaults that are known to not work reliably.
> >
> > How about implementing a replacement function for "cp" ourselves? It
> > seems pretty trivial to do. We could use that on Unixes as well, which
> > would keep the differences between Win32 and other platforms smaller,
> > and thus ensure the codepath gets more testing.
> >
> > (Sorry for jumping into the discussion so late, I didn't follow this
> > thread earlier, and just read it now in the archives while looking at
> > the patch.)
> If you've heard complaints about any of this from users, I haven't.
> AFAIK we're doing this because it *might* cause a problem. Bear in mind
> that link is the preferred performance option, not copy. So AFAICS we're
> tuning a secondary option on one specific port, without it being a
> raised issue and in an area of code that will be superceded in the next
> release.
> So further embellishments would be a long way down my own priority list,
> putting it politely. Yet I have no objections to the suggestion overall;
> we have done that already for alter tablespace.

OK, based on these observations I think we need to learn more about the
issues before making any changes to our code.

Bruce Momjian <bruce(at)momjian(dot)us>

+ If your life is a hard drive, Christ can be your backup. +

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Huxton 2008-07-01 15:22:05 Re: Does anything dump per-database config settings? (was Re: ALTER DATABASE vs pg_dump)
Previous Message Marko Kreen 2008-07-01 15:13:26 Re: Latest on CITEXT 2.0

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2008-07-01 18:09:28 Re: [PATCHES] TRUNCATE TABLE with IDENTITY
Previous Message Tom Lane 2008-07-01 13:56:13 Re: [UPDATED] A GUC variable to replace PGBE_ACTIVITY_SIZE