Re: [HACKERS] taking stdbool.h into use

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Wed, Mar 21, 2018 at 07:48:02AM -0400, Peter Eisentraut wrote:
>> I've pushed the configure tests. Let's see what they say.

> At least the buildfarm is green. Browsing the buildfarm logs manually
> is kind of annoying for any normal human being. I guess that you have
> access to the database holding all this data, which could make that
> easier to look. What are those telling about SIZEOF_BOOL in
> pg_config.h?

AFAIK, the pginfra team will give access to the buildfarm database
to anyone reasonably well known in the community, so if you want
to poke through that, just ask. In the meantime, here's what
I just got from

select distinct sysname, l from
(select sysname, unnest(string_to_array(log_text, E'\n')) as l from build_status_log
where log_stage = 'configure.log' and snapshot > '2018-03-20') ss
where l ~ 'bool'
order by 1

sysname | l
---------------+-----------------------------------------------------------------------------
aholehole | checking for stdbool.h that conforms to C99... yes
aholehole | checking size of bool... 1
anole | checking for stdbool.h that conforms to C99... yes
anole | checking size of bool... 1
caiman | checking for stdbool.h that conforms to C99... yes
caiman | checking size of bool... 1
calliphoridae | checking for stdbool.h that conforms to C99... (cached) yes
calliphoridae | checking for stdbool.h that conforms to C99... yes
calliphoridae | checking size of bool... 1
calliphoridae | checking size of bool... (cached) 1
capybara | checking for stdbool.h that conforms to C99... yes
capybara | checking size of bool... 1
castoroides | checking for stdbool.h that conforms to C99... no
castoroides | checking size of bool... 0
chub | checking for stdbool.h that conforms to C99... yes
chub | checking size of bool... 1
clam | checking for stdbool.h that conforms to C99... yes
clam | checking size of bool... 1
conchuela | checking for stdbool.h that conforms to C99... yes
conchuela | checking size of bool... 1
coypu | checking for stdbool.h that conforms to C99... yes
coypu | checking size of bool... 1
crake | Mar 21 09:15:52 checking for stdbool.h that conforms to C99... yes
crake | Mar 21 09:15:59 checking size of bool... 1
crake | Mar 21 09:37:25 checking for stdbool.h that conforms to C99... (cached) yes
crake | Mar 21 09:37:25 checking size of bool... (cached) 1
crake | Mar 21 11:46:41 checking for stdbool.h that conforms to C99... (cached) yes
crake | Mar 21 11:46:41 checking size of bool... (cached) 1
crake | Mar 21 12:38:09 checking for stdbool.h that conforms to C99... (cached) yes
crake | Mar 21 12:38:09 checking size of bool... (cached) 1
crake | Mar 21 15:38:50 checking for stdbool.h that conforms to C99... (cached) yes
crake | Mar 21 15:38:50 checking size of bool... (cached) 1
crake | Mar 21 18:37:24 checking for stdbool.h that conforms to C99... (cached) yes
crake | Mar 21 18:37:24 checking size of bool... (cached) 1
culicidae | checking for stdbool.h that conforms to C99... (cached) yes
culicidae | checking for stdbool.h that conforms to C99... yes
culicidae | checking size of bool... 1
culicidae | checking size of bool... (cached) 1
curculio | checking for stdbool.h that conforms to C99... yes
curculio | checking size of bool... 1
dangomushi | checking for stdbool.h that conforms to C99... yes
dangomushi | checking size of bool... 1
dromedary | checking for stdbool.h that conforms to C99... (cached) yes
dromedary | checking for stdbool.h that conforms to C99... yes
dromedary | checking size of bool... 1
dromedary | checking size of bool... (cached) 1
dunlin | checking for stdbool.h that conforms to C99... yes
dunlin | checking size of bool... 1
francolin | checking for stdbool.h that conforms to C99... (cached) yes
francolin | checking for stdbool.h that conforms to C99... yes
francolin | checking size of bool... 1
francolin | checking size of bool... (cached) 1
fulmar | checking for stdbool.h that conforms to C99... yes
fulmar | checking size of bool... 1
gharial | checking for stdbool.h that conforms to C99... yes
gharial | checking size of bool... 1
grison | checking for stdbool.h that conforms to C99... yes
grison | checking size of bool... 1
guaibasaurus | checking for stdbool.h that conforms to C99... yes
guaibasaurus | checking size of bool... 1
handfish | checking for stdbool.h that conforms to C99... yes
handfish | checking size of bool... 1
hornet | checking for stdbool.h that conforms to C99... yes
hornet | checking size of bool... 1
jacana | Mar 21 12:51:12 checking for stdbool.h that conforms to C99... yes
jacana | Mar 21 12:53:25 checking size of bool... 1
katydid | checking for stdbool.h that conforms to C99... yes
katydid | checking size of bool... 1
lapwing | checking for stdbool.h that conforms to C99... yes
lapwing | checking size of bool... 1
loach | checking for stdbool.h that conforms to C99... yes
loach | checking size of bool... 1
locust | checking for stdbool.h that conforms to C99... (cached) yes
locust | checking for stdbool.h that conforms to C99... yes
locust | checking size of bool... 4
locust | checking size of bool... (cached) 4
longfin | checking for stdbool.h that conforms to C99... (cached) yes
longfin | checking for stdbool.h that conforms to C99... yes
longfin | checking size of bool... 1
longfin | checking size of bool... (cached) 1
lorikeet | checking for stdbool.h that conforms to C99... (cached) yes
lorikeet | checking for stdbool.h that conforms to C99... yes
lorikeet | checking size of bool... 1
lorikeet | checking size of bool... (cached) 1
lousyjack | checking for stdbool.h that conforms to C99... (cached) yes
lousyjack | checking for stdbool.h that conforms to C99... yes
lousyjack | checking size of bool... 1
lousyjack | checking size of bool... (cached) 1
macaque | checking for stdbool.h that conforms to C99... yes
macaque | checking size of bool... 1
magpie | checking for stdbool.h that conforms to C99... yes
magpie | checking size of bool... 1
mantid | checking for stdbool.h that conforms to C99... yes
mantid | checking size of bool... 1
moonjelly | checking for stdbool.h that conforms to C99... (cached) yes
moonjelly | checking for stdbool.h that conforms to C99... yes
moonjelly | checking size of bool... 1
moonjelly | checking size of bool... (cached) 1
mule | checking for stdbool.h that conforms to C99... (cached) yes
mule | checking for stdbool.h that conforms to C99... yes
mule | checking size of bool... 1
mule | checking size of bool... (cached) 1
mylodon | checking for stdbool.h that conforms to C99... (cached) yes
mylodon | checking for stdbool.h that conforms to C99... yes
mylodon | checking size of bool... 1
mylodon | checking size of bool... (cached) 1
nightjar | checking for stdbool.h that conforms to C99... (cached) yes
nightjar | checking for stdbool.h that conforms to C99... yes
nightjar | checking size of bool... 1
nightjar | checking size of bool... (cached) 1
okapi | checking for stdbool.h that conforms to C99... yes
okapi | checking size of bool... 1
piculet | checking for stdbool.h that conforms to C99... (cached) yes
piculet | checking for stdbool.h that conforms to C99... yes
piculet | checking size of bool... 1
piculet | checking size of bool... (cached) 1
prairiedog | checking for stdbool.h that conforms to C99... (cached) yes
prairiedog | checking for stdbool.h that conforms to C99... yes
prairiedog | checking size of bool... 4
prairiedog | checking size of bool... (cached) 4
prion | checking for stdbool.h that conforms to C99... (cached) yes
prion | checking for stdbool.h that conforms to C99... yes
prion | checking size of bool... 1
prion | checking size of bool... (cached) 1
protosciurus | checking for stdbool.h that conforms to C99... no
protosciurus | checking size of bool... 0
quokka | checking for stdbool.h that conforms to C99... yes
quokka | checking size of bool... 1
rhinoceros | checking for stdbool.h that conforms to C99... (cached) yes
rhinoceros | checking for stdbool.h that conforms to C99... yes
rhinoceros | checking size of bool... 1
rhinoceros | checking size of bool... (cached) 1
rover_firefly | checking for stdbool.h that conforms to C99... yes
rover_firefly | checking size of bool... 1
seawasp | checking for stdbool.h that conforms to C99... (cached) yes
seawasp | checking for stdbool.h that conforms to C99... yes
seawasp | checking size of bool... 1
seawasp | checking size of bool... (cached) 1
sidewinder | checking for stdbool.h that conforms to C99... yes
sidewinder | checking size of bool... 1
spurfowl | checking for stdbool.h that conforms to C99... yes
spurfowl | checking size of bool... 1
sungazer | checking for stdbool.h that conforms to C99... yes
sungazer | checking size of bool... 1
termite | checking for stdbool.h that conforms to C99... yes
termite | checking size of bool... 1
tern | checking for stdbool.h that conforms to C99... yes
tern | checking size of bool... 1
treepie | checking for stdbool.h that conforms to C99... yes
treepie | checking size of bool... 1
(150 rows)

I don't think all of the slower buildfarm members have checked in
yet, but so far it's looking like ancient-macOS is the only platform
with sizeof(bool) different from 1.

regards, tom lane