Re: Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option.
Date: 2008-03-26 17:16:31
Message-ID: 29520.1206551791@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
>>> Strengthen warnings about using pg_dump's -i option.
>>
>> The proposed TODO item was not about doing this, it was about removing
>> the option altogether. AFAICS it's a foot-gun and nothing else --- why
>> do we have it?

> I thought the simple fix was to just have a better warning and see how
> that works in practice. There was some concern from people about
> removing it without more feedback/warning. I am happy to remove it.

My proposal would be to continue to accept the option but just ignore it
(ie, error out on version mismatch whether or not -i is given). This
way we wouldn't break any scripts that use the option, but things would
still be safe.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2008-03-26 17:30:23 Re: Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option.
Previous Message Andrew Dunstan 2008-03-26 16:49:48 Re: pgsql: Added ECPGget_PGconn() function to ecpglib, courtesy of Mike

Browse pgsql-hackers by date

  From Date Subject
Next Message Kenneth Marshall 2008-03-26 17:18:50 Re: [GSoC] Need for advice on improving hash index performance
Previous Message David Fetter 2008-03-26 16:54:29 Re: Surfacing qualifiers