From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option. |
Date: | 2008-03-26 17:30:23 |
Message-ID: | 200803261730.m2QHUNU05276@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Tom Lane wrote:
> >> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> >>> Strengthen warnings about using pg_dump's -i option.
> >>
> >> The proposed TODO item was not about doing this, it was about removing
> >> the option altogether. AFAICS it's a foot-gun and nothing else --- why
> >> do we have it?
>
> > I thought the simple fix was to just have a better warning and see how
> > that works in practice. There was some concern from people about
> > removing it without more feedback/warning. I am happy to remove it.
>
> My proposal would be to continue to accept the option but just ignore it
> (ie, error out on version mismatch whether or not -i is given). This
> way we wouldn't break any scripts that use the option, but things would
> still be safe.
A larger question is why the option was added in the first place.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-03-26 18:40:40 | Re: Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option. |
Previous Message | Tom Lane | 2008-03-26 17:16:31 | Re: Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option. |
From | Date | Subject | |
---|---|---|---|
Next Message | Pedro Belmino | 2008-03-26 17:40:05 | HELP |
Previous Message | David Fetter | 2008-03-26 17:27:53 | Re: Surfacing qualifiers |