From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
Subject: | Re: pg_recvlogical.c doesn't build with --disable-integer-datetimes |
Date: | 2017-02-17 17:21:45 |
Message-ID: | 29306.1487352105@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I wrote:
> Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
>> Since commit 7c030783a5bd07cadffc2a1018bc33119a4c7505 it seems that $SUBJECT.
> Hmm ... I thought we had at least one buildfarm member still testing
> --disable-integer-datetimes. Evidently somebody needs to close that
> gap.
The plot thickens: we *do* have one such critter, mandrill, but for some
reason it's not generating any complaint about this. Must be a very
lax compiler.
My own compilers don't generate errors either, only warnings. Maybe
we could catch this sort of thing mechanically with a critter configured
with -Werror as well as --disable-integer-datetimes, but I'm a tad
hesitant to have a buildfarm machine configured with -Werror. We'd
be raising the stakes quite a bit on keeping the code warning-free
for a specific compiler that might prove to be picky in silly ways.
But if it were a pretty mainstream compiler that hadn't shown much
evidence of wanting to throw useless warnings, maybe that's fine.
Thoughts?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-02-17 17:31:07 | Re: Index corruption with CREATE INDEX CONCURRENTLY |
Previous Message | Peter Geoghegan | 2017-02-17 17:17:35 | Re: Index corruption with CREATE INDEX CONCURRENTLY |