Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: YunQiang Su <wzssyqa(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build
Date: 2019-06-22 23:21:40
Message-ID: 29166.1561245700@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

YunQiang Su <wzssyqa(at)gmail(dot)com> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> 于2019年6月23日周日 上午6:37写道：
>> So I now think your original proposal was about the best way to do this,
>> though I'd tweak it to make the test be "#if __mips_isa_rev < 2", as

> here we should use #if __mips < 2 instead of __mips_isa_rev .

OK, will do.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2019-06-23 15:31:48 BUG #15869: Custom aggregation returns null when parallelized
Previous Message YunQiang Su 2019-06-22 22:59:44 Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build