From: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Greg Stark <stark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: shared-memory based stats collector - v70 |
Date: | 2022-08-10 07:37:01 |
Message-ID: | 28ff49ef-46f8-0fb3-da67-ea903d3ef7e1@amazon.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 8/9/22 6:40 PM, Andres Freund wrote:
> Hi,
>
> On 2022-08-09 12:18:47 +0200, Drouvot, Bertrand wrote:
>> What do you think about adding a function in core PG to provide such
>> functionality? (means being able to retrieve all the stats (+ eventually add
>> some filtering) without the need to connect to each database).
> I'm not that convinced by the use case, but I think it's also low cost to add
> and maintain, so if somebody cares enough to write something...
Ack.
>
> The only thing I would "request" is that such a function requires more
> permissions than the default accessors do. I think it's a minor problem that
> we allow so much access within a database right now, regardless of object
> permissions, but it'd not be a great idea to expand that to other databases,
> in bulk?
Agree that special attention would need to be pay around permissions.
Something like allow its usage if member of pg_read_all_stats?
Regards,
--
Bertrand Drouvot
Amazon Web Services: https://aws.amazon.com
From | Date | Subject | |
---|---|---|---|
Next Message | Drouvot, Bertrand | 2022-08-10 07:52:02 | Fix a typo in pgstatfuncs.c |
Previous Message | Dilip Kumar | 2022-08-10 07:33:45 | Re: SUBTRANS: Minimizing calls to SubTransSetParent() |