Re: PG_GETARG_GISTENTRY?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Mark Dilger <hornschnorter(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG_GETARG_GISTENTRY?
Date: 2017-04-05 20:12:23
Message-ID: 28827.1491423143@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Mark Dilger <hornschnorter(at)gmail(dot)com> writes:
> I have written a patch to fix these macro definitions across src/ and contrib/.
> Find the patch, attached. All regression tests pass on my Mac laptop.

Thanks for doing the legwork on that. This seems a bit late for v10,
especially since it's only cosmetic, but please put it in the first
v11 commitfest.

> I don't find any inappropriate uses of _P where _PP would be called for. I do,
> however, notice that some datatypes' functions are written to use PG_GETARG_*_P
> where PG_GETARG_*_PP might be more efficient.

Yeah. I think Noah did some work in that direction already, but I don't
believe he claimed to have caught everything. Feel free to push further.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2017-04-05 20:27:02 Re: PG_GETARG_GISTENTRY?
Previous Message Mark Dilger 2017-04-05 20:04:29 Re: PG_GETARG_GISTENTRY?