Re: Rewriting PL/Python's typeio code

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Anthony Bykov <a(dot)bykov(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Rewriting PL/Python's typeio code
Date: 2017-11-15 15:23:13
Message-ID: 28605.1510759393@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Anthony Bykov <a(dot)bykov(at)postgrespro(dot)ru> writes:
> I have checked your patch. Everything looks fine for me, but I have some doubts:

Thanks for reviewing!

> 1. In file plpy_exec.c there is a typo on line 347:
> "... We use the result and resultin[should be here "g"?] variables...

No, "resultin" is the name of the variable. Maybe that wasn't a good
choice of name, though --- do you have a better idea?

> 2. In file plpy_cursorobject.c there is a non-volatile variable "elem" used in try-except construction. Is that OK?

Hm, my compiler didn't complain about that. Did yours? The variable
is not changed inside the PG_TRY, so according to my ideas of how
this works, it should be OK. Also, it was like that before, and no
one has reported a problem.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2017-11-15 15:25:34 pgsql: Add hooks for session start and session end
Previous Message David Steele 2017-11-15 15:21:02 Re: [HACKERS] pg audit requirements