Re: Rewriting PL/Python's typeio code

From: Anthony Bykov <a(dot)bykov(at)postgrespro(dot)ru>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Rewriting PL/Python's typeio code
Date: 2017-11-15 11:08:23
Views: Raw Message | Whole Thread | Download mbox
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: not tested
Spec compliant: not tested
Documentation: tested, passed

I have checked your patch. Everything looks fine for me, but I have some doubts:
1. In file plpy_exec.c there is a typo on line 347:
"... We use the result and resultin[should be here "g"?] variables...
2. In file plpy_cursorobject.c there is a non-volatile variable "elem" used in try-except construction. Is that OK?

Anthony Bykov
Postgres Professional:
The Russian Postgres Company

The new status of this patch is: Waiting on Author

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jeevan Chalke 2017-11-15 12:01:03 Re: [HACKERS] Partition-wise aggregation/grouping
Previous Message Huong Dangminh 2017-11-15 10:55:39 RE: User defined data types in Logical Replication