Re: Notices for redundant operations

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Notices for redundant operations
Date: 2003-09-05 23:55:44
Message-ID: 28146.1062806144@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> I found a few notices and warnings that inform you that the command you
> are executing has no effect because the object is already in the state you
> want it. I think these are useless, and there is also some inconsistency.
> Does someone want to defend keeping them?

Do you think the commands should just silently do nothing? That seems
strange to me. I like giving a NOTICE (not WARNING though, those guys
should be changed).

I guess the best argument for putting out a notice is that there's some
chance the user is making a mistake, eg, telling you SET NOT NULL when
what he really wanted to do was DROP NOT NULL. If that argument doesn't
impress people then I suppose being silent is the thing to do.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message andrew 2003-09-06 01:09:19 Re: Stats Collector Error 7.4beta1 and 7.4beta2
Previous Message Tom Lane 2003-09-05 23:48:44 Re: FK type mismatches?