| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Rosser Schwarz <rosser(dot)schwarz(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Subject: | Re: Patch: add --if-exists to pg_recvlogical |
| Date: | 2017-09-15 11:15:32 |
| Message-ID: | 27F24BA7-3DE7-4A9D-87F8-F7962691CBD7@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 09 Sep 2017, at 06:05, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>
> On Sat, Sep 2, 2017 at 5:22 AM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>> <varlistentry>
>> + <term><option>--if-exists</option></term>
>> + <listitem>
>> + <para>
>> + Do not error out when <option>--drop-slot</option> or
>> <option>--start<option> are
>> + specified and a slot with the specified name does not exist.
>> + </para>
>> + </listitem>
>> + </varlistentry>
>>
>> I understand the --drop-slot part. But I don't understand what it means
>> to ignore a missing replication slot when running --start.
>
> Also "<option>--start<option>" breaks the documentation build (missing
> slash on the closing tag).
This patch is "Waiting for Author” due to the above review comments from Peter
and Thomas. Do you think you will have time to address these shortly so we can
move this patch further in the process?
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thom Brown | 2017-09-15 11:16:22 | Re: SendRowDescriptionMessage() is slow for queries with a lot of columns |
| Previous Message | Ashutosh Bapat | 2017-09-15 10:11:23 | Re: Partition-wise join for join between (declaratively) partitioned tables |