| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove libpq.rc, use win32ver.rc for libpq |
| Date: | 2020-01-09 09:56:32 |
| Message-ID: | 279bb570-8106-cda7-64f6-95f3942908a6@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-01-06 09:02, Michael Paquier wrote:
> - FILEFLAGSMASK 0x17L
> + FILEFLAGSMASK VS_FFI_FILEFLAGSMASK
> Are you sure with the mapping here? I would have thought that
> VS_FF_DEBUG is not necessary when using release-quality builds, which
> is something that can be configured with build.pl, and that it would
> be better to not enforce VS_FF_PRERELEASE all the time.
Note that there is FILEFLAGSMASK and FILEFLAGS. The first is just a
mask that says which bits in the second are valid. Since both libpq.rc
and win32ver.rc use FILEFLAGS 0, it doesn't matter what we set
FILEFLAGSMASK to. But currently libpq.rc uses 0x3fL and win32ver.rc
uses 0x17L, so in order to unify this sensibly I looked for a
well-recognized standard value, which led to VS_FFI_FILEFLAGSMASK.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2020-01-09 10:04:27 | Re: [PATCH] Resolve Parallel Hash Join Performance Issue |
| Previous Message | Peter Eisentraut | 2020-01-09 09:49:10 | Re: Change atoi to strtol in same place |