| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Kris Jurka <books(at)ejurka(dot)com> |
| Cc: | Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, gorm(dot)andersen(at)sun(dot)com |
| Subject: | Re: compiler warnings on the buildfarm |
| Date: | 2007-07-13 01:28:31 |
| Message-ID: | 27687.1184290111@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Kris Jurka <books(at)ejurka(dot)com> writes:
> So pam_message ** isn't const.
Ah, thanks. I see luna_moth is giving the same warning, so it's still
not const in Solaris 11 either.
Is it worth working around this? It's strictly cosmetic AFAICS.
The main issue in my mind would be how to determine whether to use
const or not. If all Solaris releases are like this, and can be
expected to stay that way, I'd be inclined to just put a "#define
PAM_CONV_PROC_NOT_CONST" in include/port/solaris.h and drive the
function declaration off that. If there's a version dependency
involved then it gets a lot more complicated, and might not be worth
the trouble.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeremy Drake | 2007-07-13 02:45:39 | Re: compiler warnings on the buildfarm |
| Previous Message | Heikki Linnakangas | 2007-07-13 00:27:33 | Re: compiler warnings on the buildfarm |