From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "Brendan Jurd" <direvus(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Error in from_char() for field 'D'? |
Date: | 2006-11-24 22:23:51 |
Message-ID: | 27327.1164407031@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
"Brendan Jurd" <direvus(at)gmail(dot)com> writes:
> However, in from_char(), the reverse is not true. Looking at the code
> snippet above, the digit is scanned straight into tmfc->d unaltered
> (this value is later copied directly to tm->tm_wday circa line 3394).
> Unless I'm missing something, when converting to text, 'D' yields 1-7,
> but when converting back from text, 'D' expects 0-6.
Although this does look like a bug, I'm not sure it matters, because
AFAICS there is no code path that will look at the value of tm_wday
while constructing a timestamp value from a struct tm. I'm inclined
not to risk messing with it just before RC1 unless a visible fault
can be demonstrated.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2006-11-24 22:25:58 | Re: [CORE] RC1 blocker issues |
Previous Message | Andrew Dunstan | 2006-11-24 22:07:07 | Re: RC1 blocker issues |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2006-11-24 23:41:41 | Re: Error in from_char() for field 'D'? |
Previous Message | Tom Lane | 2006-11-24 19:08:34 | Re: [PERFORM] Direct I/O issues |