Re: Fixing busted citext function declarations

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "David E(dot) Wheeler" <david(at)justatheory(dot)com>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Fixing busted citext function declarations
Date: 2015-05-12 00:01:01
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

"David E. Wheeler" <david(at)justatheory(dot)com> writes:
> On May 5, 2015, at 9:40 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> In
>> it's revealed that the citext extension misdeclares its versions of
>> regexp_matches(): they should return SETOF text[] but they're marked
>> as returning just text[].

> I wanted to make sure my backport was fixed for this, but it turns out it was already fixed as of this commit:


> Note that I credited you for the spot --- way back in October 2009! Pretty confused how the same change wasnt made to the core contrib module back then.

Me too. Something fell through the cracks rather badly there :-(.
Would you check your commit history to see if anything else got missed?

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2015-05-12 00:20:16 Re: pg_basebackup vs. Windows and tablespaces
Previous Message Andres Freund 2015-05-11 23:25:25 Re: Multi-xacts and our process problem