Re: btree_gin and btree_gist for enums

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: emre(at)hasegeli(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: btree_gin and btree_gist for enums
Date: 2016-11-05 15:46:51
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> The real problem here is that enum_cmp_internal assumes that
> fcinfo->flinfo has been set up, and DirectFunctionCallN doesn't, it sets
> it to NULL.
> The patch below cures the problem. I'm not sure if there is a better
> way. Thoughts?

That may be a good fix for robustness purposes, but it seems pretty horrid
from an efficiency standpoint. Where is this call, and should we be
modifying it to provide a flinfo?

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-11-05 15:52:09 Re: MinSizeOfXactInvals defined twice
Previous Message Andrew Dunstan 2016-11-05 15:26:33 Re: btree_gin and btree_gist for enums