| From: | Anton Voloshin <a(dot)voloshin(at)postgrespro(dot)ru> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Reorganize GUC structs |
| Date: | 2026-06-22 08:15:50 |
| Message-ID: | 270ae9e7-85c6-487d-b02b-a994af56710b@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
On 19/11/2025 10:57, Peter Eisentraut wrote:
> Ok, committed that way.
in fce7c73fb (Sort guc_parameters.dat alphabetically by name) two
extraneous newlines have been kept in the guc_parameters.dat: before
archive_command and before seq_page_cost. I suggest to remove them,
since they don't seem to mark any important spots anyway, see the
attached patch.
Found by accident after re-sorting guc_parameters.dat in our fork with
sort_guc_parameters.pl (also attached just in case). This is a
single-use script, not meant to be robust or tidy.
Best regards,
Anton Voloshin
Postgres Professional, The Russian Postgres Company
https://postgrespro.ru
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Remove-extraneous-newlines-from-guc_parameters.dat.patch | text/x-patch | 1.2 KB |
| sort_guc_parameters.pl | application/x-perl | 508 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nazir Bilal Yavuz | 2026-06-22 08:17:44 | Re: Fix handling of copy_file_range() return value |
| Previous Message | Xuneng Zhou | 2026-06-22 08:14:08 | Re: 048_vacuum_horizon_floor.pl hangs due to wakeup lost inside LockBufferForCleanup |