Re: Kudos for Reviewers -- straw poll

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Christopher Browne <cbbrowne(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Mailing Lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Kudos for Reviewers -- straw poll
Date: 2013-06-27 18:17:25
Message-ID: 26973.1372357045@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Thu, Jun 27, 2013 at 10:10:23AM -0700, Josh Berkus wrote:
>> What I would be opposed to is continuing to list the original authors in
>> the release notes and putting reviewers, testers, co-authors, etc. on a
>> separate web page. If we're gonna move people, let's move *all* of
>> them. Also, it needs to be on something more trustworthy than the wiki,
>> like maybe putting it at postgresql.org/developers/9.3/

> I think you will have trouble keeping those two lists synchronized. I
> think you will need to create a release note document that includes all
> names, then copy that to a website and remove the names just before the
> release is packaged.

Unless Bruce is doing more work than I think he is, the attribution data
going into the release notes is just coming from whatever the committer
said in the commit log message. I believe that we've generally been
careful to credit the patch author, but I'm less confident that everyone
who merited a "review credit" always gets mentioned --- that would
require going through the entire review thread at commit time, and I for
one can't say that I do that.

If we're going to try harder to ensure that reviewers are credited,
it'd probably be better to take both the commit log and the release
notes out of that loop.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-06-27 18:22:43 Re: Patch for fail-back without fresh backup
Previous Message Fabien COELHO 2013-06-27 18:17:10 Re: [PATCH] add --progress option to pgbench (submission 3)