Re: Another dead configure test

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Another dead configure test
Date: 2022-08-18 18:20:46
Message-ID: 2695333.1660846846@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2022-08-18 13:00:28 -0400, Tom Lane wrote:
>> I wondered about that, but we do need TCL_SHARED_BUILD in configure
>> itself, and the PGAC_EVAL_TCLCONFIGSH macro is going to AC_SUBST it.
>> We could remove the line in Makefile.global but I don't think that
>> buys much, and it might be more confusing not less so.

>> From the meson-generates-Makefile.global angle I like fewer symbols that have
> to be considered in Makefile.global.in :). But even leaving that aside, I
> think it's clearer to not have things in Makefile.global if they're not used.

> But it's obviously not important.

Yeah, I'm not excited about it either way --- feel free to change
if you'd rather.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-08-18 18:45:46 Re: Making Vars outer-join aware
Previous Message vignesh C 2022-08-18 17:41:30 Re: Skipping schema changes in publication