| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Another dead configure test |
| Date: | 2022-08-18 17:20:50 |
| Message-ID: | 20220818172050.diqr5hoi4h2eniwi@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-08-18 13:00:28 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > Looks good, except that it perhaps could go a tad further: TCL_SHARED_BUILD
> > isn't used either afaics?
>
> I wondered about that, but we do need TCL_SHARED_BUILD in configure
> itself, and the PGAC_EVAL_TCLCONFIGSH macro is going to AC_SUBST it.
> We could remove the line in Makefile.global but I don't think that
> buys much, and it might be more confusing not less so.
From the meson-generates-Makefile.global angle I like fewer symbols that have
to be considered in Makefile.global.in :). But even leaving that aside, I
think it's clearer to not have things in Makefile.global if they're not used.
But it's obviously not important.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-08-18 17:26:08 | Re: pg_auth_members.grantor is bunk |
| Previous Message | Tom Lane | 2022-08-18 17:00:28 | Re: Another dead configure test |