| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code for Wi |
| Date: | 2018-09-19 15:55:01 |
| Message-ID: | 26882.1537372501@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> I have spent a large portion of my morning trying to test all the
> solutions proposed, and a winner shows up. ...
> - win32-open-laurenz.patch, which enforces to text mode only if binary
> mode is not defined, which maps strictly to what pre-11 is doing when
> calling the system _open or _fopen. And surprisingly, this is proving
> to pass all the tests I ran: bincheck (including pgbench and pg_dump),
> upgradecheck, recoverycheck, check, etc. initdb --pwfile is not
> complaining to me either.
I'm OK with this approach. I wonder though what happens if you take
away the "#ifdef FRONTEND" and just enforce that one or the other mode
is selected always. That would seem like a sensible solution rather
than a wart to me ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2018-09-19 15:56:15 | Re: pgsql: Add support for nearest-neighbor (KNN) searches to SP-GiST |
| Previous Message | Tom Lane | 2018-09-19 14:35:25 | Re: pgsql: Add support for nearest-neighbor (KNN) searches to SP-GiST |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2018-09-19 16:30:52 | Re: doc - add missing documentation for "acldefault" |
| Previous Message | Tom Lane | 2018-09-19 15:47:36 | Re: Code of Conduct plan |