| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code for Wi |
| Date: | 2018-09-19 23:58:20 |
| Message-ID: | 20180919235820.GA1338@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Sep 19, 2018 at 11:55:01AM -0400, Tom Lane wrote:
> I'm OK with this approach. I wonder though what happens if you take
> away the "#ifdef FRONTEND" and just enforce that one or the other mode
> is selected always. That would seem like a sensible solution rather
> than a wart to me ...
Thanks, I have pushed the solution from Laurenz to maintain pure
compatibility. The origin of the failures reported by pg_dump actually
comes from a mismatch with pg_hba.conf in the way users and/or databases
are parsed. I am glad that we have tests for the full range of ASCII
characters in TAP so as it is easy to detect regressions at early
stages. We could try to manipulate more setmode calls like the one in
miscinit.c so as authentication gets the right call. I am not sure of
other side effects though...
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2018-09-20 02:23:21 | pgsql: Defer restoration of libraries in parallel workers. |
| Previous Message | Michael Paquier | 2018-09-19 23:56:42 | pgsql: Enforce translation mode for Windows frontends to text with open |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-09-20 00:03:31 | Re: heap_sync seems rather oblivious to partitioned tables (wal_level=minimal) |
| Previous Message | Thomas Munro | 2018-09-19 23:51:22 | SIGDANGER and oomd |