Re: [COMMITTERS] pgsql: Remove arbitrary ALTER TABLE .. ADD COLUMN restriction.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Remove arbitrary ALTER TABLE .. ADD COLUMN restriction.
Date: 2011-01-26 22:04:59
Message-ID: 26784.1296079499@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Yeah, I wasn't aware of that. I'll go revert, but I think I'll also
> add a big fat comment, because this is entirely non-obvious,

What I think would actually be helpful would be to improve the error
message. I'm not sure if it's practical to pass down the specific
reason(s) why we need to throw error, but if not, we could consider a
wishy-washy HINT along the lines of "This could be because of X, Y,
or Z".

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2011-01-26 22:19:34 pgsql: Fix compiler warnings
Previous Message Robert Haas 2011-01-26 21:34:06 Re: [COMMITTERS] pgsql: Remove arbitrary ALTER TABLE .. ADD COLUMN restriction.

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-01-26 22:12:00 Re: ALTER TYPE 3: add facility to identify further no-work cases
Previous Message Robert Haas 2011-01-26 22:01:17 Re: .gitignore patch for coverage builds