Re: Add spin_delay() implementation for Arm in s_lock.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Blake, Geoff" <blakgeof(at)amazon(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add spin_delay() implementation for Arm in s_lock.h
Date: 2021-12-11 19:16:24
Message-ID: 266904.1639250184@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Blake, Geoff" <blakgeof(at)amazon(dot)com> writes:
> Have a tiny patch to add an implementation of spin_delay() for Arm64 processors to match behavior with x86's PAUSE instruction. See negligible benefit on the pgbench tpcb-like workload so at worst it appears to do no harm but should help some workloads that experience some lock contention that need to spin.

Given the very wide variety of ARM implementations out there,
I'm not sure that we want to take a patch like this on the basis of
exactly zero evidence. It could as easily be a net loss as a win.
What did you test exactly?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Rob Gansevles 2021-12-11 20:06:28 Building postgresql from sources, statically linked, linux
Previous Message Tom Lane 2021-12-11 19:12:06 Re: Dubious usage of TYPCATEGORY_STRING