Re: pgsql: Make float4byval and float8byval configurable on MSVC.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Magnus Hagander <mha(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make float4byval and float8byval configurable on MSVC.
Date: 2008-04-21 17:19:55
Message-ID: 26610.1208798395@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Magnus Hagander wrote:
>> Make float4byval and float8byval configurable on MSVC.

> Should we now remove the entries for these 2 defines in pg_config.h.win32 ?

It looked to me like the patch-as-applied relied on their being there.
I thought it was a bit ugly though. +1 for reverting my change to
pg_config.h.win32 and making the script insert the correct #defines in
all four cases.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2008-04-21 17:26:33 Re: pgsql: Make float4byval and float8byval configurable on MSVC.
Previous Message Andrew Dunstan 2008-04-21 16:55:55 Re: pgsql: Make float4byval and float8byval configurable on MSVC.